search

OCA / hr

Odoo Human Resources Addons
GNU Affero General Public License v3.0
219 stars 672 forks source link

[17.0][MIG] hr_employee_relative: Migration to 17.0 #1382

Closed ppyczko closed 2 months ago

ppyczko commented 4 months ago

Module migrated to version 17.0

cc https://github.com/APSL 158255

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

Issue https://github.com/OCA/hr/issues/1291

Saran440 commented 4 months ago

/ocabot migration hr_employee_relative

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andres-pcg commented 2 months ago

Hey @pedrobaeza by any chance, do you know who is the maintainer or can you please help us out with this merge?

Thanks in advance.

Regards,

pedrobaeza commented 2 months ago

@Saran440 may help. I see controversial to strip the years float field to integer.

andres-pcg commented 2 months ago

Thanks you! @pedrobaeza .

@Saran440 your feedback is really important and welcomed here. So this PR can be merge. Thanks.

Saran440 commented 2 months ago

@andrp92 I think we should add separate fields to store age_year, age_month, and age_day to capture all details. This way, we can accommodate any projects or countries that might require age in terms of months or days. (allow invisible it if not need)

What do you think?

However, I tested this module and it worked. :+1:

andres-pcg commented 2 months ago

@Saran440 It sounds reasonable. However, please notice that it was already managed in a single field back in:

But yes, I think that can be improved. What do you think @ppyczko?

ppyczko commented 2 months ago

@Saran440 @andrp92 thank you for your feedback! I added the requested changes, let me know if there's anything else!

Saran440 commented 2 months ago

@ppyczko Could you split commit

  1. [MIG] --> for standard migration
  2. [ENH] --> for enhance field float to integer. we will can backport this commit.
ppyczko commented 2 months ago

@Saran440 done, thanks!

pedrobaeza commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1382-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 44c086bc1272b57cb6041aed90a038a2978db43d. Thanks a lot for contributing to OCA. ❤️