OCA / hr

Odoo Human Resources Addons
GNU Affero General Public License v3.0
216 stars 667 forks source link

Validation Error in hr_public_holidays module v11 #569

Closed burhan-vakharia closed 5 years ago

burhan-vakharia commented 5 years ago

Odoo Version - v11 Community

1) Create a new Public Holiday. 2) Add a new Public holiday line. 3) Select the date, add name and untick the Date may change Boolean.

Now try to save the Public Holiday, it will give a Validation Error - Screenshot Link - https://prnt.sc/mzviim .

Video URL - https://nimb.ws/BGXD7x

nikul-serpentcs commented 5 years ago

@pedrobaeza @mreficent Can you please check it?

SSanfilippo commented 5 years ago

Hi, have any feedback about this error? Also I cannot use the module for odoo 11 for same problem of burhan.

Best regards, Simone

moylop260 commented 5 years ago

@SSanfilippo @nikul-serpentcs @burhan-vakharia Could you check the following fix https://github.com/OCA/hr/pull/590 from @luistorresm, please?

SSanfilippo commented 5 years ago

Hi, I update the module on my enviroment, but I have always the error.

The reference of my error is: [oggetto con referenza: date - date]

luistorresm commented 5 years ago

Hello @SSanfilippo

You have updated the module? In your Odoo instance?

SSanfilippo commented 5 years ago

Yes @luistorresm, I had downloaded the source from github, then I extract in my addons folder the hr_public_holidays folder. I check also if the two modified files are presents, and yes are modified.

luistorresm commented 5 years ago

Maybe is missing make -u hr_public_holidays or in the apps update manually the module, because was changed the view.

Regards

SSanfilippo commented 5 years ago

I make the update manually, better I restart odoo service then as developer mode update all apps. I use windows version, probably forgot a step?

luistorresm commented 5 years ago

Yes @SSanfilippo

Please open the apps view and search hr_public_holidays, open it and press Update

SSanfilippo commented 5 years ago

Hi, good news (and sorry for my forgotten operation). I update the module in apps and later public holiday work fine.

luistorresm commented 5 years ago

Hello @moylop260 @max3903

Could be closed this ticket?

Regards

SSanfilippo commented 4 years ago

Hi at all, probably in Odoo 12 there is the same problem.

image