search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[14.0][ADD] github_connector_branch_options #102

Closed Volodiay622 closed 1 year ago

legalsylvain commented 1 year ago

Same remarks as in #101

Hi @Volodiay622 Thanks for your contribution ! That's a great addition.

however I don't see the need to create a new module. (this module does not add any additional dependency + adds an optional useful feature). I would be more in favor of making a modification to the existing github_connector module.

What do you think about it ?

ivs-cetmix commented 1 year ago

Same remarks as in #101

Hi @Volodiay622 Thanks for your contribution ! That's a great addition.

however I don't see the need to create a new module. (this module does not add any additional dependency + adds an optional useful feature). I would be more in favor of making a modification to the existing github_connector module.

What do you think about it ?

I think this is a good idea. We will open a new PR for that. Meanwhile could you please do a brief review just to ensure we don't have any major issues with the code?

legalsylvain commented 1 year ago

Meanwhile could you please do a brief review just to ensure we don't have any major issues with the code?

Very quick overview. Lgtm. But I dont use this module anymore. I just developed it some years ago for the OCA.

ivs-cetmix commented 1 year ago

Meanwhile could you please do a brief review just to ensure we don't have any major issues with the code?

Very quick overview. Lgtm. But I dont use this module anymore. I just developed it some years ago for the OCA.

Ok thank you! Meanwhile just curious: what are you using instead now?

Volodiay622 commented 1 year ago

Very quick overview. Lgtm. But I dont use this module anymore. I just developed it some years ago for the OCA.

Hi, thanks for the feedback!

legalsylvain commented 1 year ago

what are you using instead now?

Nothing !

Volodiay622 commented 1 year ago

will be reopened for the github_connector_odoo module