[15.0][FIX] github_connector*: Misc changes

OCA / interface-github

Tools to interact with github from Odoo

GNU Affero General Public License v3.0

46 stars 77 forks source link

[15.0][FIX] github_connector*: Misc changes #104

Closed victoralmau closed 1 year ago

victoralmau commented 1 year ago

Misc changes:

[x] github_connector: Code refactor.
[x] github_connector_odoo: Code refactor.
[x] github_connector_odoo: Set the correct access rules for odoo.module.version.rule.info

Locked by:

[x] https://github.com/OCA/interface-github/pull/105

Please @pedrobaeza can you review it?

@Tecnativa

victoralmau commented 1 year ago

Ok, I understand (although this is not related to these changes).

What approach do you propose? While perhaps not the best strategy, I think that if you click on the 'Analyze Source Code' button you should analyze it again in case something has changed (or with cron).

pedrobaeza commented 1 year ago

It's a bit related, as the patch should be to remove the lines of unexisting rules, but maybe it's better to put an ondelete="cascade" to let the system to do it.

And about the strategy, it should be:

Create a new info line if not exists for the rule.
Update the existing one if exists.

victoralmau commented 1 year ago

Code refactoring in both modules according to your comments.

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-104-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at b607169bd742e35e75752f38b13776327411ab63. Thanks a lot for contributing to OCA. ❤️