search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[ADD] github_connector_pull_request #110

Open SirAionTech opened 1 year ago

SirAionTech commented 1 year ago

nice work ! code review. No test. I wonder if we should add a cron to synchronize PR regularly.

like in the core module : https://github.com/OCA/interface-github/blob/14.0/github_connector/data/ir_cron.xml

Thanks for your review! I was looking forward to your feedback specifically because you implemented the core modules. I added the CRON

SirAionTech commented 1 year ago
  • If we install github_connector, we expect to have the possibility to fetch also the PRs, not only the branches, and the code ? ...

Proposing to improve the existing module. What do you think ?

I see Pull Requests as a temporary object, I think most users should only be interested in the main branches. The ordinary user might then be not interested in the Pull Requests, so it should not install the additional module.

We implemented this module because we are also interested in what is the work in progress of some repositories.

did you thought to fetch also comments ?

No

github-actions[bot] commented 8 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

SirAionTech commented 8 months ago

Any news on this one?

legalsylvain commented 8 months ago

I'm abstaining on this one!

github-actions[bot] commented 4 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

SirAionTech commented 4 months ago

Rebased on 14.0.