search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[16.0][MIG] github_connector: Migration to version 16.0 #118

Closed carolinafernandez-tecnativa closed 7 months ago

carolinafernandez-tecnativa commented 9 months ago

@Tecnativa TT45633

@pedrobaeza @victoralmau

pedrobaeza commented 7 months ago

Is this still WIP?

carolinafernandez-tecnativa commented 7 months ago

Is this still WIP?

no, it is ready for review Thanks!

victoralmau commented 7 months ago

Please check all tabs of all menus to display the data correctly (colspan), some examples:

* Organizations > Github

* Teams > Github

* Repositories > Github

This is still pending (I haven't seen any changes to it), can you check it?

carolinafernandez-tecnativa commented 7 months ago

03f944e

I have changed on this: https://github.com/OCA/interface-github/commit/03f944e2c34c335516c999bcd0a9bcf010845749

On which section is not displaying well or could you please give me an example ? thanks! I have checked and it looks okay.

carolinafernandez-tecnativa commented 7 months ago

Code review OK.

Can you check "Light Sync" and "Full Sync" buttons in "Github" tabs to make them display a little better?

I could't get a better display for them, do you have any idea how to do it?

pedrobaeza commented 7 months ago

/ocabot migration github_connector

pedrobaeza commented 7 months ago

/ocabot migration github_connector

OCA-git-bot commented 7 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-118-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 31a788fc17837190e4c1d3928c29bc10b87c329a. Thanks a lot for contributing to OCA. ❤️