search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[15.0][IMP] github_connector_odoo: Add maintainers #122

Closed victoralmau closed 7 months ago

victoralmau commented 7 months ago

Add maintainers

Please @pedrobaeza can you review it?

@Tecnativa TT48258

pedrobaeza commented 7 months ago

Please do this directly in 16

legalsylvain commented 7 months ago

Just a string containing the elements separated by comma is enough IMO.

Hum not so simple. Having a dedicated table allow more information, better statistic, etc... In the other hand, the github_connector base module add a github login on res_partner so, maybe this information is redondant, and module should be associated to partners in a new field maintainer_ids = field.Many2many(comodel_name="res.partner")

pedrobaeza commented 7 months ago

All that "future" things may come later, but for now, having an extra model with all its burden is too much IMO, and for our use case, which is the important thing, it's enough.

About using github users, better not, as that means that you should have them populated and that they actually exists (which can't be the case due to old alias, typos, etc).

victoralmau commented 7 months ago

Changes done.

OCA-git-bot commented 7 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-122-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at b73861e3b755d9aae4005ceda474bd7fedbd5d9e. Thanks a lot for contributing to OCA. ❤️