search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[WIP][11.0][IMP]Add maintainer(s) to Odoo modules #25

Closed StephanRozendaal closed 1 year ago

StephanRozendaal commented 6 years ago

Add maintainers to the Odoo modules, they are set-up in the same way as the 'odoo.authors' are.

RoelAdriaans commented 6 years ago

I think this should be in the github_connector_oca module, since the maintainers key is only in their module ( https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L12 ) and google docs document: https://docs.google.com/document/d/1ewkGkHzaKgtvnZZhp0ugSHiKZhlo3lechmGwsJ4OdNc/edit#

But Odoo has the maintainer key, but that looks like a lot of garbage.. :)

Which one should we use? (CC @sbidoul @elicoidal )

pedrobaeza commented 6 years ago

Please rebase and solve conflicts.

elicoidal commented 6 years ago

About the design, I'm asking myself if it's not better to use the res.partner model instead of creating a new model "odoo.maintainer". The maintainer is a github login, and res.partner has github login since it inherits from abstract_github_model. What do you think ?

Agree with the idea indeed

RoelAdriaans commented 6 years ago

Connecting to res.partner could be an idea, but for CampToCamp, are modules maintained by the individual github users, or directly linked to the @camptocamp account?

If it's an individual, the res.partner can be linked the the main partner, via the parent_id. What if that persons leaves camptocamp but keeps maintaining that module?

(And maybe for camptocamp it's not an issue because they have superate github accounts for their developers, but this is a hypothetical case..)

elicoidal commented 6 years ago

The users are linked to the company as followed: screenshot from 2018-10-06 17-26-16

So I think it is fine. If they leave the company, you can have to cases:

Depending on the case the attribution would follow either the company or the individual: nothing we can really do about it

MiquelRForgeFlow commented 5 years ago

@StephanRozendaal what is the status of this PR? would you rebase it, resolve conflicts and attend last comments?

pedrobaeza commented 4 years ago

Is this still needed?

OpenCode commented 2 years ago

Is this still needed?

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.