search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

12.0 fix dep #35

Closed sergiocorato closed 5 years ago

sergiocorato commented 5 years ago

Perhaps is my fault, but the only way to install github_connector was change dep from git to gitpython

pedrobaeza commented 5 years ago

I'm afraid it's correct as it is:

~$ sudo pip3 install GitPython
Requirement already satisfied: GitPython in /usr/local/lib/python3.6/dist-packages
Requirement already satisfied: gitdb2>=2.0.0 in /usr/local/lib/python3.6/dist-packages (from GitPython)
Requirement already satisfied: smmap2>=2.0.0 in /usr/local/lib/python3.6/dist-packages (from gitdb2>=2.0.0->GitPython)
~$ python3
Python 3.5.2 (default, Nov 23 2017, 16:37:01)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import git
>>> import GitPython
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'GitPython'
sergiocorato commented 5 years ago

I'm afraid it's correct as it is:

~$ sudo pip3 install GitPython
Requirement already satisfied: GitPython in /usr/local/lib/python3.6/dist-packages
Requirement already satisfied: gitdb2>=2.0.0 in /usr/local/lib/python3.6/dist-packages (from GitPython)
Requirement already satisfied: smmap2>=2.0.0 in /usr/local/lib/python3.6/dist-packages (from gitdb2>=2.0.0->GitPython)
~$ python3
Python 3.5.2 (default, Nov 23 2017, 16:37:01)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import git
>>> import GitPython
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'GitPython'

perhaps I do something wrong? the log is:

pip install odoo12-addon-github-connector
Collecting odoo12-addon-github-connector
Using cached https://files.pythonhosted.org/packages/82/55/aef8096dd0e5b2521d87e05d12572e8e0d2ed8ffe27fa8712271608463a1/odoo12_addon_github_connector-12.0.1.0.0-py3-none-any.whl
Requirement already satisfied: odoo<12.1dev,>=12.0a in ./venv/lib/python3.6/site-packages (from odoo12-addon-github-connector) (12.0.post20190120)
Collecting git (from odoo12-addon-github-connector)
Could not find a version that satisfies the requirement git (from odoo12-addon-github-connector) (from versions: )
No matching distribution found for git (from odoo12-addon-github-connector)
pedrobaeza commented 5 years ago

The problem is then in the setup file declaring properly the mapping dependency. cc @sbidoul

sergiocorato commented 5 years ago

The problem is then in the setup file declaring properly the mapping dependency. cc @sbidoul

To download the module, I had to change:

'external_dependencies': {
    'python': ['git'],

to 

'external_dependencies': {
    'python': ['GitPython'],

Then to install the module, I reversed the change. I dont't know the solution so far.

sbidoul commented 5 years ago

@sergiocorato setup.py needs to be adapted. Look at external_dependencies_override in setuptools-odoo documentation.

Can you please update your PR?

BTW, I still kinda hope that Odoo will consider https://github.com/odoo/odoo/pull/25549 to avoid this kind of surprise.

sergiocorato commented 5 years ago

thanks @sbidoul see #36