Closed Tardo closed 4 years ago
Ready to review
@Tardo Do you also get those errors when you test it locally or do I have to do some configuration or something extra?
Please remove #44, that it's insecure.
Commits ordered and suggested changes applied!
I can't test the functionality properly because my account use 2FA. @ernestotejeda please, check if you get the same errors. In my test i only get "max tries reached".
I took this PR, so main changes are:
Ready to be reviewed
I removed group_by key from context of the actions that are returned in a python method
ping @pedrobaeza
Changes done
changes done @chienandalu
@chienandalu , @Tardo when you have a chance, update your review status :blush:
Changes done
Ok! changes done... tested on local and works fine. I think that this module need a "revamp" in Odoo 14.0 to use modern Github API's (GraphQL API v4).
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-47-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 81f93d967558d9270102b5f5c21f2b1e84b271bd. Thanks a lot for contributing to OCA. ❤️
cc @tecnativa TT20653