OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[13.0][MIG] github_connector: Migration to 13.0 #47

Closed Tardo closed 4 years ago

Tardo commented 4 years ago

cc @tecnativa TT20653

Tardo commented 4 years ago

Ready to review

ernestotejeda commented 4 years ago

@Tardo Do you also get those errors when you test it locally or do I have to do some configuration or something extra?

pedrobaeza commented 4 years ago

Please remove #44, that it's insecure.

Tardo commented 4 years ago

Commits ordered and suggested changes applied!

I can't test the functionality properly because my account use 2FA. @ernestotejeda please, check if you get the same errors. In my test i only get "max tries reached".

ernestotejeda commented 4 years ago

I took this PR, so main changes are:

ernestotejeda commented 4 years ago

Ready to be reviewed

ernestotejeda commented 4 years ago

I removed group_by key from context of the actions that are returned in a python method

ernestotejeda commented 4 years ago

ping @pedrobaeza

ernestotejeda commented 4 years ago

Changes done

ernestotejeda commented 4 years ago

changes done @chienandalu

ernestotejeda commented 4 years ago

@chienandalu , @Tardo when you have a chance, update your review status :blush:

ernestotejeda commented 4 years ago

Changes done

Tardo commented 4 years ago

Ok! changes done... tested on local and works fine. I think that this module need a "revamp" in Odoo 14.0 to use modern Github API's (GraphQL API v4).

pedrobaeza commented 4 years ago

/ocabot merge nobump

OCA-git-bot commented 4 years ago

This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-47-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 4 years ago

Congratulations, your PR was merged at 81f93d967558d9270102b5f5c21f2b1e84b271bd. Thanks a lot for contributing to OCA. ❤️