OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[13.0][IMP] github_connector_odoo: Code analysis #64

Closed victoralmau closed 2 years ago

victoralmau commented 4 years ago

Implements Analysis source code in odoo module versions, now add new field called "has_odoo_addons" (boolean) in Analysis rule that allow (if defined) analyze odoo_module_versions and save info about it

In 'Repository Branch' / 'Code Analysis' show the info too related to Analysis rules odoo_module_versions

Locked by:

Please @pedrobaeza can you review it?

@Tecnativa TT25583

victoralmau commented 3 years ago

Ping @pedrobaeza

victoralmau commented 3 years ago

Sorry, it's not ready yet. It's necessary to add test and be sure to work fine analyze action.

pedrobaeza commented 3 years ago

Please comment when ready.

victoralmau commented 3 years ago

Ready to review it now.

victoralmau commented 3 years ago

IMO it's finally ready to review.

pedrobaeza commented 2 years ago

@cesar-tecnativa please review this PR

pedrobaeza commented 2 years ago

/ocabot merge major

pedrobaeza commented 2 years ago

Please fw-port it directly to v15

OCA-git-bot commented 2 years ago

This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-64-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at 3c8cfb8c544c324ea4a594bd2850a0c94fbf64d2. Thanks a lot for contributing to OCA. ❤️

victoralmau commented 2 years ago

Please fw-port it directly to v15

The module does not yet exist in v15 (PR exists). Do you think it's better to add this change to v14 + merge it and then add it to the PR of v15 migration?

pedrobaeza commented 2 years ago

OK, let's include it in v14 as well