[13.0][FIX] github_connector: Use correct error messages

OCA / interface-github

Tools to interact with github from Odoo

GNU Affero General Public License v3.0

46 stars 77 forks source link

[13.0][FIX] github_connector: Use correct error messages #72

Closed joao-p-marques closed 3 years ago

joao-p-marques commented 3 years ago

The error message on a failed login depends on the GH auth method being used. If the user selected a token, there won't be a login to show the error in the exception thrown. This makes the error message adapt to the type of auth chosen.

@Tecnativa TT30343

ping @pedrobaeza @CarlosRoca13

pedrobaeza commented 3 years ago

/ocabot merge patch

OCA-git-bot commented 3 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-72-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at 9f0ca70151f7810ab3b94b4ef1b8f79ccaaa2569. Thanks a lot for contributing to OCA. ❤️