search

OCA / interface-github

Tools to interact with github from Odoo
GNU Affero General Public License v3.0
46 stars 77 forks source link

[14.0][FIX] github_connector_*, fix smart button open actions #85

Closed GSLabIt closed 2 years ago

GSLabIt commented 2 years ago

@pedrobaeza it seems odoo broke something in permission for action, this is the nth case it's needed the fix.

Have you more infos?

pedrobaeza commented 2 years ago

It's an intended change, and included in the migration guide:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

(the point The access to ir.actions.* objects...)

pedrobaeza commented 2 years ago

Fast-tracking this as straight-forward:

/ocabot merge patch

OCA-git-bot commented 2 years ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-85-by-pedrobaeza-bump-patch, awaiting test results.

GSLabIt commented 2 years ago

It's an intended change, and included in the migration guide:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

(the point The access to ir.actions.* objects...)

Thanks for the hint, i noticed they changed code using the model instead:

action = self.env["ir.actions.actions"]._for_xml_id("external_id")

https://github.com/odoo/odoo/blob/a7f7233e0eae8ee101d745a9813cba930fd03dcb/addons/sale_crm/models/crm_lead.py#L42

to keep in mind 😅

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at 9281aaa5f019bf31e5dbcb51cc2e3293bd2174be. Thanks a lot for contributing to OCA. ❤️