search

OCA / knowledge

Odoo Document & Knowledge Management
http://www.odoo-community.org/project/22
GNU Affero General Public License v3.0
153 stars 328 forks source link

[16.0][FIX] document_url: Migration was not done properly #415

Closed etobella closed 1 year ago

etobella commented 1 year ago

This was not working. Now it should work properly....

@FernandoRomera @AntoniRomera @MRomeera

etobella commented 1 year ago

Fixes #413

@bealdav

PaulGoubert commented 1 year ago

Thank you very much @etobella

bealdav commented 1 year ago

Hi @etobella thanks a lot for this PR

It works really well with chrome, but fails with firefox 113.0.2 on Linux

Firefox doesn't open wizard when you click on Add Url

EDIT : maybe we could mention in README/usage that Add Url button is only displayed when an attachment exists (not an url link)

bealdav commented 1 year ago

@victoralmau @AntoniRomera Did you tested on runboat with firefox ?

victoralmau commented 1 year ago

@victoralmau @AntoniRomera Did you tested on runboat with firefox ?

Yes, it is tested and it works correctly.

pedrobaeza commented 1 year ago

I think for now is enough to merge this and fix the main problem:

/ocabot merge patch

@bealdav please check if you have any Firefox plugin interacting.

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-415-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 405653308c10bbec3c1ffd84b55348ee2d7624aa. Thanks a lot for contributing to OCA. ❤️

bealdav commented 1 year ago

Thanks, I have identify with firefox when it works and when it doesn't works

image

it works, sidebar, chatter is below

image

It doesn't works when I click on the button with the sidebar is on the right

It's not related to addons because it's the same behavior with another empty firefox profile

However thanks a lot for this fix. I can live with this identified problem ;-)

pedrobaeza commented 1 year ago

What about uninstalling web_chatter_position?

bealdav commented 1 year ago

web_chatter_position, is not installed, I suppose it's a native feature in Odoo 16 now to make chatter responsive

bealdav commented 1 year ago

Thanks a lot for taking care of it @pedrobaeza

PaulGoubert commented 1 year ago

Thank you all for this work. I just tested on Chrome and I see exactly the same behaviour as @bealdav. Impossible to click on "add url" once is on the right side, but working fine when it's down. At least, their is a way to make it work.

Once again, thank you @etobella @pedrobaeza