OCA / knowledge

Odoo Document & Knowledge Management
http://www.odoo-community.org/project/22
GNU Affero General Public License v3.0
153 stars 328 forks source link

[14.0] [FIX] attachment_preview: fix get_binary_extension #461

Closed renda-dev closed 6 months ago

renda-dev commented 7 months ago

Without this fix, opening a ir.ui.menu record from the "Technical" menu with an empty icon, would raise an error.

Also added a couple of test lines that would fail without this.

Fixed pre-commit in https://github.com/OCA/knowledge/pull/462

OCA-git-bot commented 6 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

aleuffre commented 6 months ago

@OCA/document-maintainers pretty small fix, could I ask for a merge?

pedrobaeza commented 6 months ago

/ocabot merge patch

OCA-git-bot commented 6 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-461-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 6 months ago

@pedrobaeza The merge process could not be finalized, because command git push origin 14.0-ocabot-merge-pr-461-by-pedrobaeza-bump-patch:14.0 failed with output:

To https://github.com/OCA/knowledge
 ! [remote rejected]   14.0-ocabot-merge-pr-461-by-pedrobaeza-bump-patch -> 14.0 (cannot lock ref 'refs/heads/14.0': is at 7bd8c295fa839075ccbb0b36e29b78071daa6002 but expected 1d2b0203a7e89dede553cc6b9229ba8326b3bb34)
error: failed to push some refs to 'https://***@github.com/OCA/knowledge'
OCA-git-bot commented 6 months ago

Congratulations, your PR was merged at 7bd8c295fa839075ccbb0b36e29b78071daa6002. Thanks a lot for contributing to OCA. ❤️

aleuffre commented 6 months ago

Not sure about the error message, but the merge seems to have succeeded anyway.

Thank you!