search

OCA / knowledge

Odoo Document & Knowledge Management
http://www.odoo-community.org/project/22
GNU Affero General Public License v3.0
153 stars 328 forks source link

[14.0][REF] document_page: set title attribute in <i> tag #477

Closed kaynnan closed 4 months ago

kaynnan commented 4 months ago

This PR aims to refactor the tag <i> to resolve a warning present in the log:

2024-04-19 19:11:20,677 1 WARNING odoo.addons.base.models.ir_ui_view: A <i> with fa class (o_kanban_image fa fa-file) must have title in its tag, parents, descendants or have text

2024-04-19 19:11:20,675 1 WARNING odoo.addons.base.models.ir_ui_view: A <i> with fa class (o_kanban_image fa fa-folder-open) must have title in its tag, parents, descendants or have text

cc @marcelsavegnago @WesleyOliveira98 @Matthwhy

kaynnan commented 4 months ago

ping @OCA/document-maintainers

OCA-git-bot commented 4 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-477-by-etobella-bump-patch, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at 4054a531ad047d68cb78cf3a386ad64664ee16e7. Thanks a lot for contributing to OCA. ❤️