search

OCA / l10n-canada

Odoo modules for Canada
https://community.odoo.com/project/42
GNU Affero General Public License v3.0
8 stars 31 forks source link

WIP: [ADD] Migrate module account_tax_expense_include to 8.0 version #72

Open joaoalf opened 9 years ago

joaoalf commented 9 years ago

Migrate module account_tax_expense_include to 8.0 version

max3903 commented 8 years ago

:+1:

mmalorni commented 8 years ago

When you try to add an item in an invoice you get this error: File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142056-72-1e40ff/openerp/addons/account/account_invoice.py", line 1225, in _compute_price taxes = self.invoice_line_tax_id.compute_all(price, self.quantity, product=self.product_id, partner=self.invoice_id.partner_id) File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142056-72-1e40ff/openerp/api.py", line 266, in wrapper return new_api(self, _args, *_kwargs) TypeError: compute_all() takes at least 4 arguments (5 given)

mmalorni commented 8 years ago

Looks like the conversion to the new api of "compute_all" doesn't work.

jbchouinard commented 7 years ago 
************* Module l10n_ca_account_check_writing.account_voucher
l10n_ca_account_check_writing/account_voucher.py:29: [W7935(missing-import-error), ] External dependency "num2words" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
From https://github.com/OCA/l10n-canada

Travis is raising this error (among others).

Should I fix this? This is not in the module touched by this PR.

ghost commented 7 years ago

@jbchouinard yes, its only one line, so its best if you fix it. Thanks

jbchouinard commented 7 years ago

I reproduced the issue noted by mmalorni, commit 3e2a52f fixes it.