Closed jeffery9 closed 2 years ago
@jeffery9 any feedback
@jeffery9 there has been no feedback in some time now. Are you going to fix the PR? do you need some help to get started?
@jeffery9 What is the license of these updates?
Ok, looks like it is AGPL
Yes, AGPL.
From: Ivan Yelizariev notifications@github.com Sent: Sunday, July 1, 2018 4:13 PM To: OCA/l10n-china l10n-china@noreply.github.com Cc: Jeffery CHEN Fan jeffery9@outlook.com; Mention mention@noreply.github.com Subject: Re: [OCA/l10n-china] port allpay into oca repo. (#16)
@jeffery9https://github.com/jeffery9 What is the license of these updates?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OCA/l10n-china/pull/16#issuecomment-401591668, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABVuLJuDAchQEZIZAbr8rBT1Dpgc64giks5uCISAgaJpZM4H-SDJ.
@jeffery9 contribution looks good but need some cleansing on format and code formatting: please make sure to change all your code so that it is PEP8 compliant. Once reformatted I will ask some technical reviewer to have a look.
One question: should not we move this PR to the tw repository (https://github.com/OCA/l10n-taiwan)?