search

OCA / l10n-china

Chinese localization of Odoo
GNU Affero General Public License v3.0
32 stars 46 forks source link

[ADD] connector_dns #24

Closed noahzaozao closed 8 years ago

noahzaozao commented 8 years ago

@elicoidal @duanyp1991 since the PR of oca_depand has been merged , I merged it to my branch and push to this PR , but it's still error with not find 'connector'. I wondering whether we should also PR the oca_dependencies.txt to the branch 9.0 ?

elicoidal commented 8 years ago

@noahzaozao You might need to rebase your PR so that the oca_dependency is included in it. If it doesnot work, I will ask some help

noahzaozao commented 8 years ago

@elicoidal I've rebase my PR with 8.0 branch , and seems it's still not work.

elicoidal commented 8 years ago

@pedrobaeza @dreispt any help is welcome here

dreispt commented 8 years ago

Sorry, Runbot is not something I can help. But you should definitely setup TravCI tests. Copying from business requirements repo would be a good start.

elicoidal commented 8 years ago

@dreisp, thanks for this piece of advice. We will proceed

elicoidal commented 8 years ago

@noahzaozao check the repo https://github.com/oca/business-requirement for the setup as it seems that this repo is not finished yet. Thanks

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.757% when pulling 21d125552739aab16512eb9e36440f09538b5670 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.757% when pulling 073bf9c472f51adc002d97ae3b05e058256fb3f0 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

noahzaozao commented 8 years ago

@elicoidal Since the travis and coverall are green , seems the runbot still can't find 'connector' from OCA

elicoidal commented 8 years ago

Added the connector in the runbot setup

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.757% when pulling 47bd6a876dd565c482101d29bee903b1d4f68412 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.463% when pulling 927c9c2d4768bf8d80afd0708d1edd274d6092d5 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.463% when pulling 927c9c2d4768bf8d80afd0708d1edd274d6092d5 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

noahzaozao commented 8 years ago

@elicoidal could you review this PR , current it's passed all checks , thanks.

dreispt commented 8 years ago

Is this is not specific to the CN licalization, shoudn't it go in a different repo, as discussed in the ML?

elicoidal commented 8 years ago

@dreispt True but a little bit more complicated than that. dnspod.cn provider could fit in the localization (it is all Chinese) but the connector should be in a more specific repo. That's why we initially pushed here (and then proposed an alternative) Anyway I am waiting for the decision on repo to eventually move them both in the final destination. In the meantime we will finetune the PR here.

elicoidal commented 8 years ago

@noahzaozao mostly the README to update to the latest template. Later on I might improve it to include a simple user manual

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.463% when pulling 354af50a3ff169297e977503a1eb3c9be38619dc on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.463% when pulling 400cb0bdf9e23eb879199ee57823592f5fa28fca on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 56.463% when pulling 400cb0bdf9e23eb879199ee57823592f5fa28fca on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f64557bbc51b488e4a35b20f08ceb378460 on OCA:8.0.

elicoidal commented 8 years ago

:+1: @guewen @lasley @pedrobaeza can you help on the review and merge?

elicoidal commented 8 years ago

@guewen @lasley @pedrobaeza: Ignore my cry for help! First we need to move forward with the infra-* repo...

elicoidal commented 8 years ago

@noahzaozao can you close this PR and transfer it to https://github.com/OCA/infrastructure-dns ? I will add that repo as dependency of this one (and remove the one from connector which is not needed anymore)

elicoidal commented 8 years ago

superseded by https://github.com/OCA/infrastructure-dns/pull/4