[IMP]add module website_event_baidu_map for v9.

OCA / l10n-china

Chinese localization of Odoo

GNU Affero General Public License v3.0

32 stars 46 forks source link

[IMP]add module website_event_baidu_map for v9. #5

Open Rona111 opened 8 years ago

elicoidal commented 8 years ago

LGTM

hparfr commented 8 years ago

Can't test it on runbot since the depencency to BaiDu js is not included.

elicoidal commented 8 years ago

@gurneyalex Do we have a way to add the baidu js in the runbot?

gurneyalex commented 8 years ago

@elicoidal I see no instructions in the README of the addon explaining what should be done, so I can't tell. Would it not be easier to bundle the required javascript in the source of the addon or to use an official 3rd party source for it?

elicoidal commented 8 years ago

@gurneyalex thanks for the reply I think it would be indeed easier to embed the library.

@Rona111 can you have a look with Noah?