search

OCA / l10n-china

Chinese localization of Odoo
GNU Affero General Public License v3.0
32 stars 46 forks source link

Chinese - Payroll #9

Closed xie8899 closed 7 years ago

xie8899 commented 8 years ago

[UPD] add a new module, Chinese - Payroll

xie8899 commented 8 years ago

cc @oca-clabot @elicoidal

xie8899 commented 8 years ago

cc @elicoidal @duanyp1991

elicoidal commented 8 years ago

LGTM

elicoidal commented 8 years ago

@xie8899 You need to create a Company Contribution Register and link all company contributions to this register.

elicoidal commented 8 years ago

:+1: @duanyp1991 @pedrobaeza could we square this. It is been used in production in our company for several months now

victormmtorres commented 7 years ago

@pedrobaeza @dreispt @moylop260 Could you review this PR?

cc @elicoidal

elicoidal commented 7 years ago

@victormartinelicocorp please review it but in general this is very specific to China so I dont think Pedro or Daniel can help

victormmtorres commented 7 years ago

@victormartinelicocorp please review it but in general this is very specific to China so I dont think Pedro or Daniel can help

I tried but for me Chinese law is also a handicap. Also I have some questions.

Technical speaking nothing to object.

IMO Functional Test is the most important here.

PEP8 and UT would be nice see if pass but Travis is not available on this repository. Also Runbot and Coveralls.

For the others reviewers a reason why setup all this rules and calculations by data files instead of leave everyone setup on DB by their own.

If these rules are suitable for every company in China we could try to give as well on the RST document or give some reference to check if it's true even if it's Chinese language

Example Rule Number 1: Here calculate Payslip for employees with Chinese nationality. 21.5 is the number of workable days every month could have is multiplied to base salary...etc.

What do you think @elicoidal?

elicoidal commented 7 years ago

@victormartinelicocorp Can you check with @noahzaozao for the travis setup and create the corresponding PR to fix all missing tools? As for the functional part, it has been in production for some month now: we will have to improve it with a new version and migrate to v10 soon. So funcional test is OK for me Later on we will create better rst README when it is stable. Let's first merge this