search

OCA / l10n-colombia

Odoo modules for Colombia
GNU Affero General Public License v3.0
7 stars 42 forks source link

First Public Module #4

Closed blaggacao closed 6 years ago

blaggacao commented 8 years ago

Hi, this is the first public release of our l10n_co_geo module, which finally is stable and production proven. I would kindly request, to put myself and @kurkop on the maintainers list for this repo, so that we can coordinate the localisation efforts. I think at this moment our legitimacy of doing so is without questioning and I would be happy to provide further information.

blaggacao commented 8 years ago

@dreispt @nhomar @pedrobaeza consider this WIP until everything gets green. I just copied the files into the directory and am yet to explore/familiarize with the l10n-oca repos structure. If you have general feedback, I'd be happy to discuss.

We would like to publish more modules as we become sure that their design is production proven and undisputed. We would really appreciate to evaluate the possibility of becoming the maintainers here.

pedrobaeza commented 8 years ago

David, about your proposal to be PSC members for Columbia, you need to write to contribute@odoo-community.org for requesting that.

blaggacao commented 8 years ago

@pedrobaeza Thanks for the review, it's a great learning experience!

All done, but pending: https://github.com/OCA/l10n-colombia/pull/4#discussion_r85482879 (Design Question) https://github.com/OCA/l10n-colombia/pull/4#discussion_r85483010 (License Question) https://github.com/OCA/l10n-colombia/pull/4#discussion_r85483149 (Licesne Question)

blaggacao commented 8 years ago

Round 2 remain pending:

https://github.com/OCA/l10n-colombia/pull/4#pullrequestreview-6343446 (Special permit to leave them there?) https://github.com/OCA/l10n-colombia/pull/4#pullrequestreview-6343450 (Establish right degree of granularity and refactor bank data) https://github.com/OCA/l10n-colombia/pull/4#pullrequestreview-6343469 (Outfactor deployment code @kurkop)

blaggacao commented 8 years ago

Let's stop for a moment, I'm working on get travis checks green, now. THen we can proceed to resolve the open points.

@pedrobaeza Meanwhile we can probably find answers to the open points?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 81.818% when pulling 06eda5ff038e09d89689bd2c66451ba98402561b on odoo-colombia:10.0 into 950c86331b10128c341b1e00d837ad2fe5da29f7 on OCA:10.0.

blaggacao commented 8 years ago

@pedrobaeza Everything is green now, I think we can continue and sort out the open points. Maybe you can release the remaining two request for changes with the following proposal:

https://github.com/OCA/partner-contact/issues/321

Meanwhile, I'm awaiting further input...

blaggacao commented 8 years ago

Here we go, with the states: https://github.com/odoo/odoo/pull/14067

pedrobaeza commented 8 years ago

David, ninguno de los contribuidores va a querer cambiar a LGPL. Tal vez deberíais plantearos cambiar vosotros a AGPL. Por mi experiencia, una inversión no se protege privatizando el código, si no todo lo contrario: se consigue que haya muchas versiones alternativas y ninguna se consolida, entrando en una lucha de localizaciones en la que ninguno sale beneficiado. En cambio, aquel que es el primero que libera totalmente (y en OCA), consigue ser "LA LOCALIZACIÓN", tener esa imagen, ese know-how, y por tanto, ser la referencia a la que contactan los leads.

blaggacao commented 8 years ago

Listo, entiendo eso. No es bloqueante para mi. Nosotros realmente no podemos irnos a AGPL porque estamos planeando acceder a fuentes no-AGPL en el futuro próximo que podría resultar en un conflicto no fácil de resolver así: Fuente A: AGPL Fuente B: Licencia Privada, que licenciamos por cuenta de nosotros Código de nosotros "C" que depende tanto de A como de B. No sabria decir como se puede resolver, pero segun mi entendimiento, simplemente no se puede. Ahora bien, si datos tan centrales introducen AGPL, ahora bien estamos perdidos.

Digamos, si obviamente, puede haber modulos AGPL, pero es un gran riesgo de tener modulos claves en AGPL creo que un approach mixto, pragmático y no-ideológico es la solución.