OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 20 forks source link

Add reconcile 11 #21

Closed EmailsGmails closed 3 years ago

EmailsGmails commented 6 years ago

Migrating the l10n_fi_reconcile module from avoinsystems to the OCA repository.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 68.8% when pulling 481a2ed2e0ec5e4fdacb76cab9cd90e8e322bc2d on avoinsystems:add_reconcile_11 into ceab2827b1ed1e56f3a1299ee6ad7115520c292d on OCA:11.0.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-10.6%) to 74.138% when pulling 173bf965ef977c0bd48d54d277bf608e25182b9a on avoinsystems:add_reconcile_11 into ac3b837e03390062d4b186d89fb4cb06cf7c8db3 on OCA:11.0.

oca-clabot commented 5 years ago

Hey @EmailsGmails, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

oca-clabot commented 5 years ago

Hey @EmailsGmails, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

aisopuro commented 5 years ago

Lint is failing:

l10n_fi_reconcile/models/account_move.py:47:80: E501 line too long (83 > 79 characters)
EmailsGmails commented 5 years ago

@aisopuro Fixed the lint issue.

oca-clabot commented 5 years ago

Hey @EmailsGmails, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

oca-clabot commented 5 years ago

Hey @EmailsGmails, We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts, OCA CLAbot

aisopuro commented 5 years ago

Lint is failing (I think because of these):

l10n_fi_reconcile/models/account_bank_statement.py:53:20: E127 continuation line over-indented for visual indent

l10n_fi_reconcile/models/account_bank_statement.py:55:21: E127 continuation line over-indented for visual indent

l10n_fi_reconcile/models/account_bank_statement.py:65:80: E501 line too long (94 > 79 characters)

l10n_fi_reconcile/models/account_bank_statement.py:69:25: E126 continuation line over-indented for hanging indent

l10n_fi_reconcile/models/account_bank_statement.py:79:80: E501 line too long (85 > 79 characters)

l10n_fi_reconcile/models/account_bank_statement.py:81:80: E501 line too long (95 > 79 characters)

l10n_fi_reconcile/models/account_bank_statement.py:83:25: E126 continuation line over-indented for hanging indent

l10n_fi_reconcile/models/account_bank_statement.py:97:25: E126 continuation line over-indented for hanging indent

l10n_fi_reconcile/models/account_bank_statement.py:113:25: E126 continuation line over-indented for hanging indent

l10n_fi_reconcile/models/account_bank_statement.py:154:26: E126 continuation line over-indented for hanging indent

l10n_fi_reconcile/models/account_bank_statement.py:189:80: E501 line too long (80 > 79 characters)

l10n_fi_reconcile/models/account_bank_statement.py:190:20: E127 continuation line over-indented for visual indent

l10n_fi_reconcile/models/account_bank_statement.py:192:21: E127 continuation line over-indented for visual indent

l10n_fi_reconcile/models/account_bank_statement.py:195:27: E127 continuation line over-indented for visual indent

l10n_fi_reconcile/models/account_bank_statement.py:197:32: E127 continuation line over-indented for visual indent

l10n_fi_reconcile/models/res_config.py:22:1: F401 'odoo.api' imported but unused
aisopuro commented 5 years ago

Test coverage too low.