[12.0][MIG] l10n_fi_payment_reference

OCA / l10n-finland

GNU Affero General Public License v3.0

4 stars 21 forks source link

[12.0][MIG] l10n_fi_payment_reference #29

Closed Menestrels closed 3 years ago

Menestrels commented 5 years ago

Migration from 11.0 to 12.0

oca-clabot commented 5 years ago

Hey @Menestrels, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Daniels Andersons daniels.andersons@avoin.systems (no github login found)

Appreciation of efforts, OCA CLAbot

coveralls commented 5 years ago

Coverage decreased (-0.9%) to 99.145% when pulling ca314b3b6707629b993a6e0b0f4be91d09ac3a99 on avoinsystems:12.0-mig-l10n_fi_payment_reference into 7b9d0d367aa73792bd4e8cc675923529a66f42d7 on OCA:12.0.

mlaitinen commented 5 years ago

Did you test how the module works in the UI? Apparently related fields in Odoo 12 are by default read-only so the payment_reference_type field in res.config cannot be changed. Also please check the codecov checks.

mlaitinen commented 4 years ago

You might not have noticed, but the payment reference field was introduced in Odoo 12: https://github.com/odoo/odoo/commit/b5bb5bd421ad5c643f72602f6a0f97a4a0eb8711

Having said that, this module should be adapted to use the existing fields instead of duplicating them.