OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 20 forks source link

Migration to version 13.0 #31

Closed OCA-git-bot closed 2 years ago

OCA-git-bot commented 5 years ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

jarmokortetjarvi commented 4 years ago

I feel like we should drop the partner_identification dependency from 13.0 version of l10n_fi_business_code.

In my opinion, there is no reason to use this module - the added field should be just a basic Char field. The business id/code that this field represents is given only once per company, it has no assignation or expiration date and it can't be changed.

The current implementation is unnecessarily complicated, as a "dumb" field would be sufficient. It would also make validating this field less complex (format validation, duplicate validation).

Is there a reason to keep the dependency?

mlaitinen commented 4 years ago

I remember that we had a discussion with other OCA people about this, but I can't find it anywhere. I very much agree that the partner_identification dependency creates unnecessary complexity and pain. The best possible solution would be a single Char field.

I vote for dropping the dependency.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.