[13.0][MIG] l10n_fi_edicode

OCA / l10n-finland

GNU Affero General Public License v3.0

4 stars 20 forks source link

[13.0][MIG] l10n_fi_edicode #32

Closed Tatider closed 3 years ago

Tatider commented 4 years ago

Migrate module to 13.0:

Upgrade structure of module.
Change einvoice_operator field name to einvoice_operator_id
Change name_get for res.partner.operator.einvoice to remove redundund field einvoice_operator_identifier from res.partner model

Improve usability and module data:

Update eInvoice Operators data
Improve eInvoice Operators Model: add type, active and menu
Add eInvoice Operator field to company and settings

oca-clabot commented 4 years ago

Hey @Tatider, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Tatiana Deribina tatiana.deribina@avoin.systems (no github login found)
Daniels Andersons daniels.andersons@avoin.systems (no github login found)

Appreciation of efforts, OCA CLAbot

jarmokortetjarvi commented 3 years ago

Sorry I've been preoccupied with something else for quite a while. This seems good to me (except the small conflict error). Any other reason for not merging this?

mlaitinen commented 3 years ago

Sorry I've been preoccupied with something else for quite a while. This seems good to me (except the small conflict error). Any other reason for not merging this?

I got rid of the conflict, but now the Travis CI doesn't pass due to some code style error. Have you seen this before?

jarmokortetjarvi commented 3 years ago

Sorry I've been preoccupied with something else for quite a while. This seems good to me (except the small conflict error). Any other reason for not merging this?

I got rid of the conflict, but now the Travis CI doesn't pass due to some code style error. Have you seen this before?

Haven't seen this. The actual error seems to be

l10n_fi_edicode/migrations/13.0.1.1.0/pre-migrate-res-partner.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

I added a README.rst locally to migrations/13.0.1.1.0/ to get a successful pre-commit. I have no idea why it would want another readme there.