search

OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 21 forks source link

14.0 mig l10n fi payment terms #43

Closed jarmokortetjarvi closed 3 years ago

jarmokortetjarvi commented 3 years ago

No payment terms are added or removed. In 12.0->13.0 migration I hinted about removing the IMMEDIATE and 30 days payment terms, but that might be detrimental for backwards-compatibility, as there may be situations where a payment term is referred by its external id or code.

sequence-field was removed as it has been added to core.

_order has been removed as it has been added to core. This module used sequence,name and core uses sequence,id, but I think it's better to not override the order for so minor difference. The overridden _order was initially to introduce the sequence to order anyway.

Diff https://github.com/OCA/l10n-finland/compare/13.0...jarmokortetjarvi:14.0-mig-l10n_fi_payment_terms?expand=1

mlaitinen commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-43-by-mlaitinen-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-43-by-mlaitinen-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at 39d64d2984635e601b695724a7c8b1f998982795. Thanks a lot for contributing to OCA. ❤️