search

OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 21 forks source link

14.0 mig l10n fi edicode #44

Closed jarmokortetjarvi closed 3 years ago

jarmokortetjarvi commented 3 years ago

No functional changes between 13.0 and 14.0. Added simple tests for partner and edicode operator. Changed Liaison Technologies Oy to Opentext Oy

Changes between 13.0 and 14.0 https://github.com/jarmokortetjarvi/l10n-finland/commit/2093ab90a24fce85b8c508eba2ee1d734fd9815e and https://github.com/OCA/l10n-finland/compare/13.0...jarmokortetjarvi:14.0-mig-l10n_fi_edicode

OCA-git-bot commented 3 years ago

Hi @jarmokortetjarvi! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

aisopuro commented 3 years ago

The changes LGTM.

Looking at the coverage comments, it looks like adding tests for name_get (I.e. looking at display_name) and doing a name_search should get the necessary coverage.

jarmokortetjarvi commented 3 years ago

Ping @aisopuro for a re-approve

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

aisopuro commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

Sorry @aisopuro you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

aisopuro commented 3 years ago

Sorry @aisopuro you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Brutal. I guess it's all you @mlaitinen

mlaitinen commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-44-by-mlaitinen-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at a7e8bc7f6131170339dde4302e4424a820630c24. Thanks a lot for contributing to OCA. ❤️