search

OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 20 forks source link

14.0 mig l10n fi business code validate #46

Closed jarmokortetjarvi closed 2 years ago

jarmokortetjarvi commented 2 years ago

Migrated business code validation from 12.0 to 14.0. Module version 13.0 is missing, but this could be back-ported to 13.0 just by changing the version number.

Actual diff https://github.com/OCA/l10n-finland/compare/12.0...jarmokortetjarvi:14.0-mig-l10n_fi_business_code_validate?expand=1

Only functional change for the earlier version is the addition of country_id to the constraint. In earlier versions you can have an incorrect business code if you set it before setting the country.

The diff looks large as the validation was in partner category, which was dropped when the business code field was simplified into a Char-field.

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mlaitinen commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-46-by-mlaitinen-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at dc5ebceb175767e1131aae8e6088da7e3e5e1207. Thanks a lot for contributing to OCA. ❤️