search

OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 20 forks source link

[MIG] 15.0 l10n_fi_sale_refund_payment_reference #50

Closed nedaszilinskas closed 2 years ago

nedaszilinskas commented 2 years ago

Migration from 13.0

nedaszilinskas commented 2 years ago

Request for the review :) Ping @aisopuro @mlaitinen @OCA/community-maintainers.

Now that in the 15.0 branch this module doesn't exist I had to manually copy it from 13.0, which loses all migration diff. and is a little less than ideal. Do you have any advice/recommendations/ref. to the manual on how to avoid that?

dreispt commented 2 years ago

Yes. Please see #47 , it explains the process needed to keep the module commit history.

mlaitinen commented 2 years ago

In particular this section: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#technical-method-to-migrate-a-module-from-140-to-150-branch

nedaszilinskas commented 2 years ago

Thank you, @dreispt @mlaitinen! I must have been blind to miss that before 🤦 I've pushed the update.

anikeenko-viktor commented 2 years ago

@mlaitinen Since that was approved, could you please merge it?

mlaitinen commented 2 years ago

@mlaitinen Since that was approved, could you please merge it?

I'd wait for @aisopuro's approval before merging

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mlaitinen commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-50-by-mlaitinen-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at 76eeadb8c999fd61d4d2f771f65d255fa1eca766. Thanks a lot for contributing to OCA. ❤️