search

OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 21 forks source link

[MIG] 16.0 l10n_fi_business_code #53

Closed jarmokortetjarvi closed 10 months ago

jarmokortetjarvi commented 1 year ago

Nothing changed.

Actual diff https://github.com/OCA/l10n-finland/compare/15.0...jarmokortetjarvi:16.0-mig-l10n_fi_business_code?expand=1

mlaitinen commented 1 year ago

Did you consider switching to the new res.partner.company_registry field that was introduced in Odoo 16.0? It seems like it would render this module redundant.

image

jarmokortetjarvi commented 1 year ago

Did you consider switching to the new res.partner.company_registry field that was introduced in Odoo 16.0? It seems like it would render this module redundant.

image

I did consider not migrating the module as company_registry basically makes another business code field obsolete, but came to a conclusion that it could be useful to support this for one more version.

It could be even better to include a migration script that moves the business_code data to company_registry and change business_code to a computed field that refers to company_registry (for compatibility reasons).

github-actions[bot] commented 10 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.