search

OCA / l10n-finland

GNU Affero General Public License v3.0
4 stars 20 forks source link

[14.0] dotfiles update needs manual intervention #57

Closed aisopuro closed 11 months ago

aisopuro commented 11 months ago

Replaces #56 as I cannot push the fix to that branch directly.

etobella commented 11 months ago

Can you change travis for Github actions? You just need to do copier update and select github :smile:

aisopuro commented 11 months ago

I ran copier update, and answered the questions to the best of my ability. It seems to have updated a fair bit more than just the test runner: https://github.com/OCA/l10n-finland/pull/57/commits/a8058c365c054f009337d0082477c884f8047096

In fact it seems to have re-introduced several things that the original @OCA-git-bot removed: https://github.com/OCA/l10n-finland/pull/57/commits/14c98a61dedaa30d1a1a6508c1f59b5963d68ffe

I'll see if I can fix the code coverage, but can you @etobella tell me if these differences are OK? It seems like I've given different answers to copier update than @OCA-git-bot did, and I just want to make sure I'm not configuring anything wrong.

etobella commented 11 months ago

You did it greatly :smile:

OCA-git-bot commented 11 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-57-by-etobella-bump-patch, awaiting test results.

OCA-git-bot commented 11 months ago

Congratulations, your PR was merged at 28d76f3be65b5380da540fb5aeab7ec2aa25a409. Thanks a lot for contributing to OCA. ❤️