search

OCA / l10n-france

France Localization for Odoo
GNU Affero General Public License v3.0
42 stars 118 forks source link

[13.0][MIG] l10n_fr_department_delivery #406

Closed BenjaHe closed 12 months ago

BenjaHe commented 1 year ago

hello @alexis-via. Thanks for the code review. This PR has a problem with Travis, but I do not understand why. Do you have any idea ?

alexis-via commented 1 year ago

Why do you inherit the wizard and not just the method _match_address() on delivery.carrier ? It seems to me that the method _match_address() is specifically designed to be inherited in this kind of cases.

alexis-via commented 1 year ago

I migrated this module to v14 using the inherit of the method _match_address() on delivery.carrier and it works well. https://github.com/OCA/l10n-france/pull/443

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.