OCA / l10n-france

France Localization for Odoo
GNU Affero General Public License v3.0
42 stars 114 forks source link

[16.0][IMP] account_statement_import_fr_cfonb: add small hook to allow to a… #431

Closed florian-dacosta closed 7 months ago

florian-dacosta commented 1 year ago

…dd more info in label

@alexis-via As you know, I have already added back some complementary label in the module, but it is still not enough. I have BNP Cfonb files that add the sale order reference in the RCN category (in case of customer bank transfer payment) In other cases, the information is useless indeed, but it is impossible not to have it in some other case...

So, in order to not pollute people that don't need it, I propose this small hook that allow to add some complementary code at demand. What do you think ?

OCA-git-bot commented 1 year ago

Hi @alexis-via, some modules you are maintaining are being modified, check this out!

florian-dacosta commented 1 year ago

@alexis-via As we talked about some time ago, I've added the RCN complentary code by default as it is used a lot by the bank and sometimes with really important information (like SO number in case of wire transfer) Can you have a quick look on the PR?

florian-dacosta commented 11 months ago

@alexis-via Friendly reminder, could you make a review on this trivial PR?

github-actions[bot] commented 7 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

florian-dacosta commented 7 months ago

@alexis-via

alexis-via commented 7 months ago

/oca merge minor

bguillot commented 7 months ago

/ocabot merge minor

OCA-git-bot commented 7 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-431-by-bguillot-bump-minor, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 9f8820d2945d230dc87b26d6a5c0c09bae4d4ee6. Thanks a lot for contributing to OCA. ❤️