Open yajo opened 7 months ago
Hi @alexis-via, @remi-filament, some modules you are maintaining are being modified, check this out!
Yes, it's very annoying that Odoo depends on old version of python-stdnum. It's a lack of respect for the excellent work of the guys of python-stdnum. By depending on such an old version, we miss all the bugfixes of the recent years.
I would not merge this. We'll find a better solution for https://github.com/OCA/oca-ci/pull/66
What about this?
@yajo I'm ok to remove the constraint on the version of python-stdnum in the manifest and explain in the README of the module that we recommend to have a version >= 1.18 to have the fix on SIRET that is included in that version.
seems fair, done.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
Thanks, bot. AFAIK this is ready to merge. I just rebased to fix conflicts.
Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies.
Besides, python-stdnum is pinned to 1.16. Thus, when applying https://github.com/OCA/oca-ci/pull/66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream.
@moduon MT-4520 @EmilioPascual