[IMP] l10n_fr_siret: warning for identical SIRET

[vvrossem]

adds a warning banner on the partner form view either

• if another partner has the same SIRET,
• or if another partner has the same SIREN but different SIRET.

[OCA-git-bot]

Hi @alexis-via, some modules you are maintaining are being modified, check this out!

[alexis-via]

I don't understand what you are trying to change here. Current implementation : warn if 2 partners have the same SIREN. Your implementation : 1) if another partner has the same SIRET, 2) or if another partner has the same SIREN but different SIRET.

As SIRET is just an extension of SIREN, your implementation is the same as the current implementation. So what's the point ?

[epanisset]

I don't understand what you are trying to change here. Current implementation : warn if 2 partners have the same SIREN. Your implementation :

1. if another partner has the same SIRET,
2. or if another partner has the same SIREN but different SIRET.

As SIRET is just an extension of SIREN, your implementation is the same as the current implementation. So what's the point ?

Hello Alexis, Basically for one of our customer, we want to have a warning if SIRET are the same. So we have added it to this oca module, but keeping also the existing siren warning as complement. A company can have 1 SIREN but multiple different SIRET (one per location)

Camptocamp for example has the same SIREN for Camptocamp Chambery & Paris but 2 different SIRET (one per location). We are just going further in the warning details.

[alexis-via]

I'm really against this change ; it adds complexity for no real benefit.