search

OCA / l10n-iran

Odoo Localization for Iran
GNU Affero General Public License v3.0
16 stars 20 forks source link

upgrade accountin to 17 (not compeleted but is a good starting point) #33

Closed hamidk1010 closed 7 months ago

pedrobaeza commented 7 months ago

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

dreispt commented 7 months ago

Thank you @hamidk1010 The migration PR needs to keep the module's commit history. You can find a detailed how to here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch Follow it carefully.

Also, we don't want multiple fix or migration steps. You should either squash later fixes into a single commit, or just amend the last commit as you go, using git commit --amend --no-edit.

hamidk1010 commented 7 months ago

i did it: https://github.com/OCA/l10n-iran/pull/35 @dreispt

hamidk1010 commented 7 months ago

continue here: https://github.com/OCA/l10n-iran/pull/35