search

OCA / l10n-iran

Odoo Localization for Iran
GNU Affero General Public License v3.0
16 stars 20 forks source link

[ADD] init l10n_ir module #34

Closed saeed-raeisi closed 7 months ago

saeed-raeisi commented 7 months ago

add l10n_ir module accounting and states data

saeed-raeisi commented 7 months ago

https://github.com/odoo/odoo/pull/97784

saeed-raeisi commented 7 months ago

.pylintrc - .pylintrc-mandatory : removed duplicate-xml-record-id

.pre-commit-config.yaml : removed id: oca-checks-odoo-module

--- update:

<!-- pylint:disable=duplicate-xml-record-id -->

saeed-raeisi commented 7 months ago

https://github.com/OCA/l10n-iran/blob/dev-15.0/l10n_ir/data/account.account.template.csv https://github.com/OCA/l10n-iran/blob/dev-15.0/l10n_ir/data/account.group.template.csv

this files need review translation From Fa to En and this file https://github.com/OCA/l10n-iran/blob/dev-15.0/l10n_ir/i18n/fa.po

pedrobaeza commented 7 months ago

Hi @saeed-raeisi

The XML-ID duplicated is a valid check for most of the occasions, as it prevents to declare 2 times the same record. The only exception is this needed trick where you need first to create the CoA, and then, assign an account.

It's better to just disable locally before the record declaration than to disable it totally in the configuration. Something like:

<!-- pylint: disable=duplicate-xml-record-id -->
saeed-raeisi commented 7 months ago

Hi @saeed-raeisi

The XML-ID duplicated is a valid check for most of the occasions, as it prevents to declare 2 times the same record. The only exception is this needed trick where you need first to create the CoA, and then, assign an account.

It's better to just disable locally before the record declaration than to disable it totally in the configuration. Something like:

<!-- pylint: disable=duplicate-xml-record-id -->

Hi This issue was fixed in the last commit

pedrobaeza commented 7 months ago

OK, now you can squash all the commits into one, and I think it's OK to merge it.

saeed-raeisi commented 7 months ago

/ocabot merge nobump

OCA-git-bot commented 7 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-34-by-saeed-raeisi-bump-nobump, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at bfa5bb5f1343542222439117222c44b3ad251583. Thanks a lot for contributing to OCA. ❤️

pedrobaeza commented 7 months ago

You haven't squashed the commits, Saeed. Please take it into account for other times.

saeed-raeisi commented 7 months ago

You haven't squashed the commits, Saeed. Please take it into account for other times.

Sorry, I thought ocabot could do that Is it possible to choose merge method for ocabot?

pedrobaeza commented 7 months ago

No, it's not possible.