search

OCA / l10n-iran

Odoo Localization for Iran
GNU Affero General Public License v3.0
16 stars 20 forks source link

[ADD][8.0]Jalali date support #4

Closed elicoidal closed 6 years ago

pedrobaeza commented 6 years ago

Why _printout suffix? Shouldn't this be web_widget_date_jalali? Shouldn't this be attached to user lang?

elicoidal commented 6 years ago

@pedrobaeza I pushed some old modules that we did for a project in Iran in order to share the knowledge. I am not sure the way it has been implemented is the best but I will not invest more time on it (other than fixing Travis). If you think it is not valid enough I can publish it in our company repo which is less strict but I though it nice for the Persian community to have some modules to get started with. As said I am open :smile:

pedrobaeza commented 6 years ago

Well, I don't have interest in this as we don't have any customer in Iran, but just saying, at least, things to add to "Known issues". I won't block of course if they are not developped, as this better than having nothing.

About the name, it's important to have the best proper one, but I don't know also the implementation, so my name is just a suggestion about what I think it does.

elicoidal commented 6 years ago

@pedrobaeza

I can improve the naming removing the _printout (but I dont think webwidget is relevant as this is much simpler than that: replacing date fields function in some printouts).

I will add some text to the known issues such as well. Thanks for your input!

elicoidal commented 6 years ago

closing wrong branch!