[ADD] l10n_mx_sat_account

OCA / l10n-mexico

Mexican Localization.

GNU Affero General Public License v3.0

3 stars 19 forks source link

[ADD] l10n_mx_sat_account #12

Closed Dangar-Serpentcs closed 4 years ago

Dangar-Serpentcs commented 4 years ago

This module provides the list of grouping accounts from the Mexican tax authority, Servicio de Administración Tributaria (SAT):

Issue #7 Depends on:

[x] #11

OCA-git-bot commented 4 years ago

Hi @max3903, some modules you are maintaining are being modified, check this out!

Dangar-Serpentcs commented 4 years ago

@max3903 Travis Failed, because module 'l10n_mx_sat_account' depends on #11

max3903 commented 4 years ago

@Dangar-Serpentcs We still need to set the SAT account on the accounts from the chart in l10n_mx (using the tag).

hdelacru commented 4 years ago

revisando

Dangar-Serpentcs commented 4 years ago

@Dangar-Serpentcs We still need to set the SAT account on the accounts from the chart in l10n_mx (using the tag).

Do you mean that we need to set all sat.account to the l10n_mx COA(Chart of Account) or some specific mapping to the account, like below screenshots Am I right ?

Selection_041

max3903 commented 4 years ago

@Dangar-Serpentcs All accounts that have tags.

@dnieto72 @oldyguy @hdelacru How is it possible to have an Odoo account grouped in multiple SAT accounts?

max3903 commented 4 years ago

@Dangar-Serpentcs Can you rebase please? #11 has been merged.

max3903 commented 4 years ago

@Dangar-Serpentcs Please review and merge https://github.com/SerpentConsultingServices/l10n-mexico/pull/1

max3903 commented 4 years ago

@Dangar-Serpentcs Can you fix the Travis error?

Dangar-Serpentcs commented 4 years ago

@Dangar-Serpentcs Can you fix the Travis error?

Sure.

max3903 commented 4 years ago

@Dangar-Serpentcs I don't know what you did but you messed up the pull request with module already merged...

Dangar-Serpentcs commented 4 years ago

@Dangar-Serpentcs I don't know what you did but you messed up the pull request with module already merged...

Dangar-Serpentcs commented 4 years ago

@Dangar-Serpentcs Can you fix the Travis error?

I fixed it Travis error only I did noting more in source of code or any other PR.

max3903 commented 4 years ago

@Dangar-Serpentcs Can you review and merge https://github.com/SerpentConsultingServices/l10n-mexico/pull/2? It implements @moylop260 suggestion.

max3903 commented 4 years ago

Ping @Dangar-Serpentcs

OCA-git-bot commented 4 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

max3903 commented 4 years ago

/ocabot merge

OCA-git-bot commented 4 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-12-by-max3903-bump-no, awaiting test results.

OCA-git-bot commented 4 years ago

Congratulations, your PR was merged at d1ee325daa5d2f793cb3b23f6c9692666e6d0beb. Thanks a lot for contributing to OCA. ❤️