search

OCA / l10n-mexico

Mexican Localization.
GNU Affero General Public License v3.0
3 stars 19 forks source link

[17.0][MIG] l10n_mx_catalogs: Migration to 17.0 #43

Closed santiagordz closed 2 months ago

santiagordz commented 3 months ago

@max3903 can you please review this?

max3903 commented 3 months ago

@azubieta

azubieta commented 3 months ago

It would be great to have a display_name compute function that mixes the code and the name (or description for those who don't have a name)

max3903 commented 3 months ago

/ocabot migration l10n_mx_catalogs

santiagordz commented 3 months ago

@azubieta @max3903 , like that?

azubieta commented 3 months ago

@santiagordz you took the long path, I was thinking on having a base abstract model that implements the function. But yes that's pretty much what the user asks. Just add a " - " between the code and the name, notice the spaces.

azubieta commented 3 months ago

Looks good to me :)

max3903 commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-43-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 7f132001d383bbcb8002f2dda1cf0e366029aa2a. Thanks a lot for contributing to OCA. ❤️