OCA / l10n-netherlands

Odoo Dutch Localization
GNU Affero General Public License v3.0
21 stars 55 forks source link

[15.0][PORT] 404 from 14.0 l10n_nl_account_tax_unece: Update account_tax_codes #409

Closed bosd closed 5 months ago

bosd commented 9 months ago

Port of #404

bosd commented 6 months ago

@thomaspaulb @NL66278 Kindly attent to this port as well :pray:

thomaspaulb commented 6 months ago

@bosd Apparently runboat failed, maybe you can rebase to retrigger

bosd commented 6 months ago

Sure! I'll try

/ocabot rebase

OCA-git-bot commented 6 months ago

Sorry @bosd you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

thomaspaulb commented 6 months ago

/ocabot rebase

OCA-git-bot commented 6 months ago

Congratulations, PR rebased to 15.0.

thomaspaulb commented 6 months ago

@sbidoul Sorry for asking, but what does it mean in this case when the runboat is Pending? Usually a rebase retriggers the build, but now I'm a bit puzzled.

sbidoul commented 6 months ago

@thomaspaulb the rebase command did not create new commits, so I suspect runboat did not notice any relevant change. It does not seem to react to close/reopen either. Try amending.

bosd commented 6 months ago

Retriggered with

git commit --amend --no-edit
git push --force-with-lease

It would be nice if the author of a pr could invoke the gitbot for the rebase. ( And retrigger tests )

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 5 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-409-by-hbrunn-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 83f1a82b2448f2a0f75bdfb06bc27bafa70dc26d. Thanks a lot for contributing to OCA. ❤️