OCA / l10n-spain

Odoo Spain Localization
https://www.aeodoo.org/estado-localizacion
GNU Affero General Public License v3.0
292 stars 520 forks source link

[13.0][IMP] delivery_gls_asm: Nuevo servicio '96 - BUSINESS PARCEL' #3530

Closed chienandalu closed 1 month ago

chienandalu commented 7 months ago

Backport de https://github.com/OCA/l10n-spain/pull/3432

cc @Tecnativa TT48760

cc @ioans73 @pedrobaeza @victoralmau

OCA-git-bot commented 7 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-3530-by-pedrobaeza-bump-minor, awaiting test results.

pedrobaeza commented 7 months ago

Parece que el sistema pip tiene algún tipo de problema... @chienandalu puedes probar a hacer un copier update a ver si sale funcionando?

OCA-git-bot commented 7 months ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-3530-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

chienandalu commented 7 months ago

Parece que el sistema pip tiene algún tipo de problema... @chienandalu puedes probar a hacer un copier update a ver si sale funcionando?

No sé muy bien qué puede suceder. Descarga los módulos pero luego parece que no encuentra el path... pasa tanto en runboat como en los tests

pedrobaeza commented 7 months ago

@sbidoul do you know what happens with runboat/CI on 13.0 ?

pedrobaeza commented 7 months ago

@sbidoul it seems on v13 there's a new problem with the CI.

dreispt commented 6 months ago

/ocabot merge minor

OCA-git-bot commented 6 months ago

On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-3530-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot commented 6 months ago

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-3530-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sbidoul commented 6 months ago

Sooo, the error here is due to lxml 5.2.1 being installed, and that one breaks Odoo. lxml 3.7.1 is pre-installed in the image. But this repo needs xmlsec, which in turn requires lxml >= 3.8, so pip installs the latest version of lxml.

The solution is to add lxml<5.2 in the manifests of addons which depend on xmlsec (with a little comment explain the reason of the upper bound).

Also, there is ongoing work to make manifestoo report such kind of errors more explicitly.

sbidoul commented 6 months ago

Alternatively, we could upgrade lxml in OCB's requirements.txt.

We could also backport https://github.com/odoo/odoo/pull/163788 in OCB and maybe test with OCB only for on older unmaintained Odoo branches.

chienandalu commented 6 months ago

Thanks a lot for your research @sbidoul ! Any favorite solution @pedrobaeza ?

pedrobaeza commented 6 months ago

Let's go with lxml<5.2 on xmlsec depending modules as the most conservative one for this old version.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pedrobaeza commented 1 month ago

/ocabot merge patch

OCA-git-bot commented 1 month ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-3530-by-pedrobaeza-bump-patch, awaiting test results.

pedrobaeza commented 1 month ago

/ocabot merge minor

OCA-git-bot commented 1 month ago

On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-3530-by-pedrobaeza-bump-minor, awaiting test results.

pedrobaeza commented 1 month ago

Hay que fusionar a mano, que no funciona el bot.