[16.0][IMP] delivery_gls_asm: Check value being sent

OCA / l10n-spain

Odoo Spain Localization

https://www.aeodoo.org/estado-localizacion

GNU Affero General Public License v3.0

272 stars 517 forks source link

[16.0][IMP] delivery_gls_asm: Check value being sent #3612

Closed hildickethan closed 3 months ago

hildickethan commented 3 months ago

Check the actual value that is being sent to GLS, since it doesn't make sense to error for 15 characters when the value you would send doesn't actually exceed that limit

My use case is that we have some clients that deliver a whole stock.picking.batch instead of stock.picking individually, therefore the reference we use is the batch's name (overwritten through _prepare_gls_asm_shipping). This started erroring when the picking reference reached 16 characters while the batch reference is still only 10

OCA-git-bot commented 3 months ago

Hi @chienandalu, some modules you are maintaining are being modified, check this out!

hildickethan commented 3 months ago

Looks good. Could you add your rationale to the commit?

Copied the PR desc to the commit

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-3612-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at c1376385b8caf761e4005212b5080b5909bcc8fa. Thanks a lot for contributing to OCA. ❤️