search

OCA / l10n-switzerland

Odoo Swiss localization
GNU Affero General Public License v3.0
53 stars 164 forks source link

[10.0] [IMP] match partner in same way as lines for reconcilation #512

Closed i-vyshnevska closed 5 years ago

i-vyshnevska commented 5 years ago

After isr reconciliation lines reconciled but they didn't have partner_id on them, as isr reconciliation totally relies on transaction_ref But partner on statement lines also needed for reports and analytic This extension searches for partner in same way as it done for isr reconcile

Technical points method reconciliation_widget_preprocess is copy pasted from odoo code all changes in preparing sql

yvaucher commented 5 years ago

@i-vyshnevska do you know if we could have copied the value of transaction_ref into ref field instead? Or is ref field already used by some other data in version 10.0 ?

EDIT: current version would make less meddling in the database.

PS: From version 13.0 we will use ref always.

i-vyshnevska commented 5 years ago

@i-vyshnevska do you know if we could have copied the value of transaction_ref into ref field instead? Or is ref field already used by some other data in version 10.0 ?

From what I see, yes, it can solve not only issue introduced in PR, all this addon will be not needed refactoring will need to be done for few addons, base_transaction_id including

yvaucher commented 5 years ago

@i-vyshnevska base_transaction_id will be dropped in version 13.0 But, for version 10.0 we can use your solution.

tschanzt commented 5 years ago

@i-vyshnevska does it also work when using the auto esr reconcile button?

i-vyshnevska commented 5 years ago

@i-vyshnevska does it also work when using the auto esr reconcile button?

yes, that preprocessing started by reconciliation wizard

yvaucher commented 5 years ago

/ocabot merge minor

OCA-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 10.0-ocabot-merge-pr-512-by-yvaucher-bump-minor, awaiting test results.

OCA-git-bot commented 5 years ago

It looks like something changed on 10.0 in the meantime. Let me try again (no action is required from you). Prepared branch 10.0-ocabot-merge-pr-512-by-yvaucher-bump-minor, awaiting test results.

OCA-git-bot commented 5 years ago

Congratulations, your PR was merged at ecb18a1aff3c0a04523f4d9545db70d93af62e00. Thanks a lot for contributing to OCA. ❤️