search

OCA / l10n-switzerland

Odoo Swiss localization
GNU Affero General Public License v3.0
53 stars 164 forks source link

[12.0] l10n_ch_payment_slip: Fix ref assignation on move lines #522

Closed grindtildeath closed 5 years ago

grindtildeath commented 5 years ago

Payment slip ref on invoice move was overwritten by the super call to invoice_validate that was done after the setting of payment slip ref on the move.

Moreover, the dependency to base_transaction_id is dropped as the reference is now written on account.move.ref field.

Linked to https://github.com/OCA/account-reconcile/pull/292

yvaucher commented 5 years ago

/ocabot merge

OCA-git-bot commented 5 years ago

On my way to merge this fine PR! Prepared branch 12.0-ocabot-merge-pr-522-by-yvaucher-bump-no, awaiting test results.

OCA-git-bot commented 5 years ago

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-522-by-yvaucher-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yvaucher commented 5 years ago

/ocabot merge

OCA-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 12.0-ocabot-merge-pr-522-by-yvaucher-bump-no, awaiting test results.

OCA-git-bot commented 5 years ago

It looks like something changed on 12.0 in the meantime. Let me try again (no action is required from you). Prepared branch 12.0-ocabot-merge-pr-522-by-yvaucher-bump-no, awaiting test results.

yvaucher commented 5 years ago

@OCA-git-bot yup you were too slow :)

OCA-git-bot commented 5 years ago

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-522-by-yvaucher-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.