[FIX] Check presence of QR IBAN before checking validity

OCA / l10n-switzerland

Odoo Swiss localization

GNU Affero General Public License v3.0

53 stars 164 forks source link

[FIX] Check presence of QR IBAN before checking validity #584

Closed vrenaville closed 3 years ago

vrenaville commented 3 years ago

Purpose We need to first check if the QR iban is filed before checking validity

https://github.com/OCA/l10n-switzerland/pull/584

yvaucher commented 3 years ago

@vrenaville I counter proposed an other fix to have _validate... function checking emptiness and making sure the constraint doesn't call validation for nothing.

@carlosserratoro Does it take take of your remark?

carlosserratoro commented 3 years ago

@carlosserratoro Does it take take of your remark?

Yes. But was just a non-blocking comment, I could live with the if :)

yvaucher commented 3 years ago

/ocabot merge patch

OCA-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 10.0-ocabot-merge-pr-584-by-yvaucher-bump-patch, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at b750cf87184af3922bb600580c3418bd0abd5520. Thanks a lot for contributing to OCA. ❤️