search

OCA / l10n-switzerland

Odoo Swiss localization
GNU Affero General Public License v3.0
53 stars 163 forks source link

[14.0][MIG] l10n_ch_pain_base #591

Closed SimoneVagile closed 1 year ago

SimoneVagile commented 3 years ago

Depends on:

SimoRubi commented 3 years ago

Can you rebase on 14.0 since https://github.com/OCA/l10n-switzerland/pull/590 has been merged?

SimoneVagile commented 3 years ago

Can you also check why is Travis failing? It is white_check_mark in 14.0

@SimoRubi l10n_ch_base_bank tests was failing.

I created this PR https://github.com/OCA/l10n-switzerland/pull/609 to fix them.

yvaucher commented 2 years ago

@SimoneVagile can you rebase? https://github.com/OCA/l10n-switzerland/pull/616 should have fixed the CI

SimoRubi commented 2 years ago

@SimoneVagile do I have to update my review?

SimoneVagile commented 2 years ago

@SimoneVagile do I have to update my review?

@SimoRubi https://github.com/OCA/l10n-switzerland/pull/609#issuecomment-1056992521

hailangvn commented 2 years ago

Good day @SimoneVagile, @SimoRubi, the travis was red because move.partner_bank_id = bank_id. Re-opening PR#609 does not have any effect because PR#616 has already made same change. There is proposed fix is to have a setting to force blank partner bank then use it in test. You can see that travis of PR#641 is green thanks to the fix. The PR#641 is now having same change with this PR and can be closed.

hailangvn commented 2 years ago

Good day @StephaneMangin, @SimoneVagile, The PR#640 has been updated and can be merged to fix travis. But for PR#641, we have lost access to update it. So please help to re-open this PR and close PR#641.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

i-vyshnevska commented 2 years ago

@SimoneVagile can you pls rebase, seems the test was fixed

michelerusti commented 2 years ago

@SimoneVagile can you pls rebase, seems the test was fixed

Since the owner of this PR is no longer working on Odoo, I've made #668 to continue this discussion

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.