search

OCA / l10n-switzerland

Odoo Swiss localization
GNU Affero General Public License v3.0
53 stars 163 forks source link

[14.0][FIX] l10n_ch_delivery_carrier_label_quickpac: missing condition for … #683

Closed StephaneMangin closed 1 year ago

StephaneMangin commented 2 years ago

Missing condition for quickpac when changing carrier on pickings

This PR https://github.com/OCA/l10n-switzerland/pull/637 introduced a bug while using onchange_carrier_id with different carrier than Quickpac.

StephaneMangin commented 2 years ago

LGTM unless travis failing

I don't know why yet, it's working locally

TDu commented 1 year ago

@StephaneMangin It needs a rebase to fix the pre-commit. And you can remove this commit https://github.com/OCA/l10n-switzerland/pull/683/commits/93b38befddf7b9e6ad493ae835c5c5352cb4ece5. And use that opportunity to improve the commit message (see https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message) Thank you. Otherwise the fix looks good.

StephaneMangin commented 1 year ago

@TDu Done !

But now there is a failed test on an independant module ebill_paynet. I'm debugging it.

StephaneMangin commented 1 year ago

Waiting for https://github.com/OCA/l10n-switzerland/pull/690 to be reviewed and merged.

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TDu commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-683-by-TDu-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at ca89c37598831b85f14db17453d7db0ceb57fc16. Thanks a lot for contributing to OCA. ❤️