Closed jguenat closed 10 months ago
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
I have no experience with this module in the previous versions, but it looks good to me (only code review). One quetion, shouldn't we put the XML files in English and provide translations instead of directly entering records in French?
Thanks for your review !
Yes it would be better but I don't know the english translation. As this is specific for switzerland I guess it's not a big deal if we put it in french, people can then translate it with weblate if needed.
@ecino could you merge it? Thanks
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-709-by-ecino-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 1600fc0ff9dc120ed833661e8759855f3aaa1597. Thanks a lot for contributing to OCA. ❤️
Migration with following refactor
reviews/opinions are welcome :)